Skip to content

MWPW-209096 - Hide Cancel button when 100% uploaded during Acrobat redirect - #917

Open
DavidKHahn wants to merge 2 commits into
stagefrom
mwpw-209096-hide-cancel-button
Open

MWPW-209096 - Hide Cancel button when 100% uploaded during Acrobat redirect#917
DavidKHahn wants to merge 2 commits into
stagefrom
mwpw-209096-hide-cancel-button

Conversation

@DavidKHahn

@DavidKHahn DavidKHahn commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #902 (MWPW-206368). Jira: https://jira.corp.adobe.com/browse/MWPW-209096

Once the upload finishes and the progress bar jumps to 100%, Unity has already committed the redirect to Acrobat, so clicking Cancel at that point can't stop it — users see Cancel "not work". Per design, hide the Cancel button from that moment.

  • transition-screen.js: new toggleCancelButton(visible); splashVisibilityController() always restores the button so it's visible on the next upload.
  • action-binder.js continueInApp(): hide Cancel as soon as the redirect is committed (before the bar fills to 100%).
image

Test plan

  • Unit tests: toggleCancelButton hide/show/no-button, restore on splash show/hide, continueInApp hides Cancel before filling the bar (action-binder 252/252)
  • Mutation tested: removing the restore fails its test
  • Lint: no new errors (same count as stage)
  • Manual QA

QA

Same Requestly setup as #902, but redirect to this branch:

  • RegEx: /^https://www\.stage\.adobe\.com/unitylibs/(.*)/
  • Redirect to: https://mwpw-209096-hide-cancel-button--unity--adobecom.aem.live/unitylibs/$1

Steps (fresh incognito, signed out) on https://www.stage.adobe.com/acrobat/online/pdf-to-word.html:

  1. Upload a PDF → Cancel is visible while uploading → Cancel returns to the drop zone.
  2. Upload again and let it finish → when the bar reaches 100%, Cancel disappears and you land in Acrobat.
  3. Go back and upload again → Cancel is visible again.

David Hahn
MWPW-209096 - Hide Cancel once redirect to Acrobat starts
f1de532 
Per design, hide the splash-screen Cancel button when continueInApp begins
(progress bar jumps to 100% and the redirect to Acrobat is committed, so
Cancel can no longer stop it). The button is restored whenever the splash
screen is shown or hidden again.

Follow-up to MWPW-206368.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aem-code-sync

aem-code-sync Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@DavidKHahn DavidKHahn mentioned this pull request Sep 29, 2026
Closed
3 of 4 tasks
@aem-code-sync

aem-code-sync Bot commented Sep 29, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 /unitylibs/ Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI
🖥️ /unitylibs/ Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI

@asonnalagi

asonnalagi commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Validated in branch.
https://stage--dc--adobecom.aem.live/drafts/nala/acrobat/online/test/pdf-to-word?unitylibs=mwpw-209096-hide-cancel-button
Cancel button is visible, until loader hits 100%.
Once loader is 100%, cancel button is Vanished.
https://github.com/user-attachments/assets/40dc21c2-44b4-4d4d-a2ae-462776d77d02

David Hahn David Hahn
MWPW-209096 - Merge latest stage into PR branch
f534b86 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@adobecom-git-stale-pr-bot adobecom-git-stale-pr-bot Bot added the stale-warning Nearing staleness; will be labeled `stale` soon label Oct 13, 2026
@adobecom-git-stale-pr-bot

adobecom-git-stale-pr-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

No activity in 7 days. Will be labeled stale at 14 days, closed at 28. Add stale-ignore to temporarily exempt this PR from stale labels only, or add both stale-ignore and autoclose-ignore to temporarily ignore both stale and autoclose states.

Rundeck job Git Stale PR Check (git-stale-pr-bot), execution 2774990, project global, run by casalino

@adobecom-git-stale-pr-bot adobecom-git-stale-pr-bot Bot added stale No recent activity and removed stale-warning Nearing staleness; will be labeled `stale` soon labels Oct 20, 2026
@adobecom-git-stale-pr-bot

adobecom-git-stale-pr-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

No activity in 14 days, labeled stale (removed automatically on new activity). Closes automatically at 28 days unless updated. Add stale-ignore to temporarily exempt this PR from stale labels only, or add both stale-ignore and autoclose-ignore to temporarily ignore both stale and autoclose states.

Rundeck job Git Stale PR Check (git-stale-pr-bot), execution 2782141, project global, run by casalino

@adobecom-git-stale-pr-bot adobecom-git-stale-pr-bot Bot added stale-warning Nearing staleness; will be labeled `stale` soon and removed stale-warning Nearing staleness; will be labeled `stale` soon labels Oct 21, 2026

This branch was successfully deployed

1 active deployment
mwpw-209096-hide-cancel-button — f534b868 Deployed Oct 5, 2026 by aem-code-sync[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxn-adobe maxn-adobe maxn-adobe approved these changes
@Ruchika4 Ruchika4 Awaiting requested review from Ruchika4
@markovicpredrag1209 markovicpredrag1209 Awaiting requested review from markovicpredrag1209
@KetakiD-Deshwandikar KetakiD-Deshwandikar Awaiting requested review from KetakiD-Deshwandikar

Assignees

@markovicpredrag1209 markovicpredrag1209

Labels

stale No recent activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidKHahn @asonnalagi @maxn-adobe @markovicpredrag1209